
review
Review the changes since a fixed point (commit, branch, tag, or merge-base) along two axes — Standards (does the code follow this repo's documented coding standards?) and Spec (does the code match what the originating issue/PRD asked for?). Runs both reviews in parallel sub-agents and reports them side by side. Use when the user wants to review a branch, a PR, work-in-progress changes, or asks to "review since X".
- Installs
- 911
- Last 24h
- —
- Trending rank
- —
- Security
- Not audited
Install
Works with every agent the skills CLI supports.
npx skills add https://github.com/vinvcn/mattpocock-skills-zh-cn --skill review- 01
Install
Run the command in your project. The CLI asks which agents to install for.
- 02
Describe the task
Ask your agent for something this skill covers. It loads review automatically when relevant.
- 03
Review the result
The agent follows the SKILL.md steps, scripts and references bundled with the skill.
SKILL.md
The instructions your agent reads when the skill is triggered.
Review
对用户提供的固定点与 HEAD 之间的 diff 做双轴 review:
- Standards — 代码是否符合这个 repo 记录下来的 coding standards?
- Spec — 代码是否忠实实现来源 issue / PRD / spec?
两个轴线都作为并行 sub-agents运行,避免互相污染 context;然后这个 skill 聚合它们的 findings。
Issue tracker 应该已经提供给你;如果缺少 docs/agents/issue-tracker.md,运行 /setup-matt-pocock-skills。
Process
1. Pin the fixed point
用户说的任何内容都是 fixed point:commit SHA、branch name、tag、main、HEAD~5 等。不要自作主张;原样传入。如果用户没有指定,询问:“Review against what — a branch, a commit, or main?” 在拿到 fixed point 前不要继续。
先捕获一次 diff command:git diff <fixed-point>...HEAD(three-dot,因此比较对象是 merge-base)。同时用 git log <fixed-point>..HEAD --oneline 记录 commits 列表。
2. Identify the spec source
按以下顺序寻找来源 spec:
- Commit messages 中的 issue references(
#123、Closes #45、GitLab!67等)— 按docs/agents/issue-tracker.md中的 workflow 获取。 - 用户作为 argument 传入的 path。
docs/、specs/或.scratch/下与 branch name 或 feature 匹配的 PRD/spec 文件。- 如果什么都找不到,询问用户 spec 在哪里。如果用户说没有 spec,Spec sub-agent 跳过并报告 “no spec available”。
3. Identify the standards sources
Repo 中任何记录代码应该如何写的内容。常见位置:
CLAUDE.md、AGENTS.mdCONTRIBUTING.mdCONTEXT.md、CONTEXT-MAP.md、per-contextCONTEXT.mdfilesdocs/adr/(architectural decisions 也是 standards).editorconfig、eslint.config.*、biome.json、prettier.config.*、tsconfig.json(machine-enforced standards;记录它们,但不要重复检查 tooling 已经检查的内容)- Repo root 或
docs/下任何STYLE.md、STANDARDS.md、STYLEGUIDE.md或类似文件
收集文件列表。Standards sub-agent 会读取它们。
4. Spawn both sub-agents in parallel
发送一条包含两个 Agent tool calls 的消息。两个都使用 general-purpose subagent。
Standards sub-agent prompt — 包含:
- 完整 diff command 和 commit list。
- Step 3 中找到的 standards-source files 列表。
- Brief:"Read the standards docs. Then read the diff. Report — per file/hunk where relevant — every place the diff violates a documented standard. Cite the standard (file + the rule). Distinguish hard violations from judgement calls. Skip anything tooling enforces. Under 400 words."
Spec sub-agent prompt — 包含:
- Diff command 和 commit list。
- Spec 的 path 或已获取内容。
- Brief:"Read the spec. Then read the diff. Report: (a) requirements the spec asked for that are missing or partial; (b) behaviour in the diff that wasn't asked for (scope creep); (c) requirements that look implemented but where the implementation looks wrong. Quote the spec line for each finding. Under 400 words."
如果缺少 spec,跳过 Spec sub-agent,并在最终报告中说明。
5. Aggregate
在 ## Standards 和 ## Spec headings 下展示两个 reports,可原样或轻微清理。不要合并或重新排序 findings;这两个轴线刻意保持分离,方便用户独立查看。
最后用一行总结:每个轴线的 findings 总数,以及被标记的最严重单个问题(如果有)。
Why two axes
一个变更可能通过其中一个轴线,但失败在另一个轴线:
- 代码符合所有 standard,但实现了错误的东西 → Standards pass, Spec fail.
- 代码完全符合 issue 要求,但破坏了项目约定 → Spec pass, Standards fail.
分开报告能避免一个轴线掩盖另一个轴线。
FAQ
What does the review skill do?
Review the changes since a fixed point (commit, branch, tag, or merge-base) along two axes — Standards (does the code follow this repo's documented coding standards?) and Spec (does the code match what the originating issue/PRD asked for?). Runs both reviews in parallel sub-agents and reports them side by side. Use when the user wants to review a branch, a PR, work-in-progress changes, or asks to "review since X".
How do I install review?
Run npx skills add https://github.com/vinvcn/mattpocock-skills-zh-cn --skill review in your project. The skills CLI detects the agents you use and copies the skill into the right folder. For Claude Code you can also place the skill folder at ~/.claude/skills/review/ (personal) or .claude/skills/review/ (project).
Which AI agents can use review?
Any agent that supports the open Agent Skills format (a folder with a SKILL.md file), including Claude Code, Codex, Cursor, GitHub Copilot, Gemini CLI, Windsurf, Cline, OpenCode and more.
Is review safe to install?
No partner security audit is available yet. Skills can run commands and scripts, so read the SKILL.md and any bundled files before installing.
Who maintains review?
It is published by vinvcn in vinvcn/mattpocock-skills-zh-cn. It has 911 recorded installs.
More from vinvcn/mattpocock-skills-zh-cn
grill-with-docs
vinvcn/mattpocock-skills-zh-cn
一个用来打磨计划或设计的持续追问式访谈,并在过程中创建文档(ADRs 和词汇表)。
setup-matt-pocock-skills
vinvcn/mattpocock-skills-zh-cn
为此仓库配置 engineering skills:设置其 issue tracker、triage labels 词汇与 domain docs 布局。在首次使用其他 engineering skills 前运行一次。
tdd
vinvcn/mattpocock-skills-zh-cn
测试驱动开发。适用于用户想用先写测试的方式构建功能或修复缺陷、提到 “red-green-refactor”,或需要集成测试时。
improve-codebase-architecture
vinvcn/mattpocock-skills-zh-cn
扫描代码库中的深化机会,生成可视化 HTML 报告,然后围绕你选中的候选项继续追问。
Popular code quality & workflow skills
grill-me
mattpocock/skills
A relentless interview to sharpen a plan or design.
improve-codebase-architecture
mattpocock/skills
Scan a codebase for deepening opportunities, present them as a visual HTML report, then grill through whichever one you pick.
handoff
mattpocock/skills
Compact the current conversation into a handoff document for another agent to pick up.
domain-modeling
mattpocock/skills
Build and sharpen a project's domain model. Use when discussing codebase terminology, writing or editing a GLOSSARY.md, or recording or editing an ADR.
codebase-design
mattpocock/skills
Shared vocabulary for designing deep modules. Use when the user wants to design or improve a module's interface, find deepening opportunities, decide where a seam goes, make code more testable or AI-navigable, or when another skill needs the deep-module vocabulary.
diagnosing-bugs
mattpocock/skills
Diagnosis loop for hard bugs and performance regressions. Use when the user says "diagnose"/"debug this", or reports something broken/throwing/failing/slow.